Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES6 Unicode escaped identifiers #941

Closed
getify opened this issue Mar 4, 2015 · 8 comments
Closed

Support ES6 Unicode escaped identifiers #941

getify opened this issue Mar 4, 2015 · 8 comments
Labels

Comments

@getify
Copy link

@getify getify commented Mar 4, 2015

The new Unicode "code point escape" form is also valid for identifiers, such as:

var \u{2B400} = 42;

AFAICT, no one has implemented this part of the grammar yet. As usual, @mathiasbynens has a bunch of great stuff about what makes a valid Unicode identifier in ES6 vs ES5, etc.


BTW:

I'm not sure, but support of this feature may just need to be that such variables are straight up hygenically renamed to something else entirely, because there's (AFAICT) no equivalent way to do those kind of identifier names in pre-ES6.

@sebmck
Copy link
Contributor

@sebmck sebmck commented Mar 4, 2015

Please request this upstream at acorn.

@getify
Copy link
Author

@getify getify commented Mar 4, 2015

@mathiasbynens
Copy link
Contributor

@mathiasbynens mathiasbynens commented Mar 5, 2015

@sebmck
Copy link
Contributor

@sebmck sebmck commented Mar 6, 2015

Will take a little longer than I hoped since acorn is radically changing it's structure and will require me to rewrite all the custom acorn extensions (ES7, Flow etc). Once acornjs/acorn#216 is merged I should be able to nut through it in a day.

@sebmck sebmck modified the milestone: 4.8.0 Mar 15, 2015
@sebmck
Copy link
Contributor

@sebmck sebmck commented Mar 18, 2015

Fixed in the experimental branch.

@sebmck sebmck closed this Mar 18, 2015
@getify
Copy link
Author

@getify getify commented Mar 18, 2015

is this going to stay only in "experimental" mode?

@sebmck
Copy link
Contributor

@sebmck sebmck commented Mar 18, 2015

No, the experimental branch is the current unstable branch (terrible name I know).

@getify
Copy link
Author

@getify getify commented Mar 18, 2015

ahh, ok, sorry for misunderstanding. thanks! :)

@lock lock bot added the outdated label Jul 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants