New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Type arguments are referred to as type parameters on some nodes #9418

Open
dsherret opened this Issue Jan 27, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@dsherret
Copy link

dsherret commented Jan 27, 2019

Bug Report

Current Behavior

Currently, some nodes with type arguments have a typeParameters property instead of typeArguments, which is slightly confusing.

This exists on:

  • TSTypeReference (ex. let myVar: MyType<string>;)
  • CallSignature (ex. someFunction<string>();)
  • TSExpressionWithTypeArguments (ex. class MyClass extends MyOtherClass<string, number> {})
  • TSImportType (ex. let myVar: import<string>("test"); -- it's in the ast, but not sure how that would be used...)

Expected behavior/code
Expected these nodes to have property typeArguments.

Possible Solution
Rename typeParameters to typeArguments (obviously a breaking change).

Additional context/Screenshots

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jan 27, 2019

Hey @dsherret! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment