New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path.isBindingIdentifier() gives inconsistent results #9425

Open
Getfree opened this Issue Jan 29, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@Getfree
Copy link

Getfree commented Jan 29, 2019

Plugin.js

module.exports = function({types: T}){
	return {
		visitor:{	
			Identifier(path){
				if( path.node.name=='c' )
					console.log( path.isBindingIdentifier() ) ;
			},
		},
	}
}

Input.js

a = {b: c} ;

a.b = c ;

Console output:

> babel -o Output.js Input.js
true
false

isBindingIdentifier says that variable c is a binding identifier on line 1, but it's not on line 2.

What's wrong here? Is this a bug?

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jan 29, 2019

Hey @Getfree! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

@Getfree

This comment has been minimized.

Copy link
Author

Getfree commented Jan 29, 2019

Here are more inconsistent cases.

Input.js

a = {b: c} ;
a = {b: +c} ;
a = {b: 2*c} ;

a.b = c ;
a.b = +c ;
a.b = 2*c ;

Console output:

> babel -o Output.js Input.js
true
true
false
false
true
false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment