New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add topLevelAwait option to transform-modules-systemjs #9426

Open
dmail opened this Issue Jan 29, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@dmail
Copy link
Contributor

dmail commented Jan 29, 2019

Feature Request

https://github.com/systemjs/systemjs is somehow compatible with basic top level await.

Unfortunately, given a file with code below:

await Promise.resolve()

transform-modules-systemjs outputs

System.register([], function (_export, _context) {
  return {
    setters: [],
    execute: function () {
      await Promise.resolve()
    })
  }
})

Passing an option like topLevelAwait: true I would like to get the following output.

System.register([], function (_export, _context) {
  return {
    setters: [],
    execute: async function () {
      await Promise.resolve()
    })
  }
})

Suggested implementation

We could replace

execute: function () {
BODY;
}

with

             execute: EXECUTE

And replace

with

         EXECUTE: t.functionDeclaration(
           null,
           [],
           t.blockStatement(path.node.body),
           false,
           options.topLevelAwait
         ),

And it may work.

Before going further, what do you think ?

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jan 29, 2019

Hey @dmail! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment