Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback values in @babel/template #9669

Open
harrysolovay opened this Issue Mar 12, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@harrysolovay
Copy link

harrysolovay commented Mar 12, 2019

Feature Request

Is your feature request related to a problem? Please describe.
I find myself often implementing the following:

const aTemplate = template`
  const a = VALUE;
`

const createA = ({VALUE = t.nullLiteral()}) =>
  aTemplate({VALUE})

Describe the solution you'd like
What I really want to do is something like this:

const createA = template(`
  const a = VALUE;
`, {
  fallbacks: {
    VALUE: t.nullLiteral(),
  },
})

Teachability, Documentation, Adoption, Migration Strategy
Not sure how this affects other packages which use the options schema... but I don't see any obvious conflicts. Please let me know if you want me to implement & PR.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Mar 12, 2019

Hey @harrysolovay! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.