Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt type for Flow #10091

Merged
merged 4 commits into from Jul 3, 2019

Conversation

@tanhauhau
Copy link
Member

commented Jun 13, 2019

Building on top of #10084,
I've fixed a few several test cases for run_babel_parser_flow_tests and removed them from the whitelist.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11015/

@tanhauhau tanhauhau force-pushed the tanhauhau:tanhauhau/fix-flow-tests branch from e63494d to 3002aa0 Jun 15, 2019

@tanhauhau tanhauhau changed the title wip: fix flow tests Fix flow tests Jun 15, 2019

@tanhauhau

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2019

hmm.. running out of memory

@tanhauhau tanhauhau force-pushed the tanhauhau:tanhauhau/fix-flow-tests branch from 3002aa0 to 77dd93c Jun 23, 2019

@tanhauhau tanhauhau changed the title Fix flow tests BigInt type for Flow Jun 23, 2019

);
}

this.unexpected(null, `Unexpected token, expected "number"`);

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Jun 27, 2019

Member
Suggested change
this.unexpected(null, `Unexpected token, expected "number"`);
this.unexpected(null, `Unexpected token, expected "number" or "bigint"`);

@nicolo-ribaudo nicolo-ribaudo merged commit f588e4e into babel:master Jul 3, 2019

5 checks passed

babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.45% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tanhauhau tanhauhau deleted the tanhauhau:tanhauhau/fix-flow-tests branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.