Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow "let" as name at lexical bindings #10099

Merged
merged 3 commits into from Jun 18, 2019

Conversation

@g-plane
Copy link
Contributor

commented Jun 15, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Spec: https://www.ecma-international.org/ecma-262/9.0/#sec-let-and-const-declarations-static-semantics-early-errors

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10953/

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10948/

@kaicataldo
Copy link
Member

left a comment

Do we need a test for const let = {} and let let = {}?

packages/babel-parser/src/parser/statement.js Outdated Show resolved Hide resolved
g-plane added 2 commits Jun 15, 2019
@g-plane

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

@nicolo-ribaudo Are there anything else that should be changed?

@kaicataldo
Copy link
Member

left a comment

🎉

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

I'm surprised that this didn't change any parser Test262 result

@nicolo-ribaudo nicolo-ribaudo merged commit 11fa246 into babel:master Jun 18, 2019

5 checks passed

babel/repl REPL preview is available
Details
buildsize No significant change
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.45% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@g-plane g-plane deleted the g-plane:disallow-binding-let branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.