Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain typescript export-from-source #10167

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@Wolvereness
Copy link
Contributor

commented Jul 5, 2019

Q                       A
Fixed Issues? Fixes #10162
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is (some of) @JLHwung's suggested changes with test case added (feel free to re-author if appropriate). In addition, a reported issue by @pixelass in the same comment thread now has a test case, but it is not a current bug, however was confirmed to have been one previously.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 5, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11054/

Copy link
Contributor

left a comment

Could you add a test case when ExportSpecifier contains as?

import _bar from "./bar";
export { _bar as bar };
@nicolo-ribaudo nicolo-ribaudo merged commit bff79e1 into babel:master Jul 5, 2019
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
buildsize No prior size to compare - 8.01 MB
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.56% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@inje inje referenced this pull request Jul 5, 2019
afc163 added a commit to ant-design/ant-design that referenced this pull request Jul 6, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.