Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[_objectSpread2] Do not use hoisted var from prev iteration #10180

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@nicolo-ribaudo
Copy link
Member

commented Jul 8, 2019

Q                       A
Fixed Issues? Fix #10166 for real
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This was an error introduced in https://github.com/babel/babel/pull/10171/files.
The helper got the keys from source, which was defined at the previous iteration.

Also, I added a test faking an old env by deleting Object.getOwnPropertyDescriptors 😎

If I had used let this would not have happened. Also, this is what happens when I merge a PR without waiting for the usual two ✔️; this bug could have been caught by more eyes looking at it.

@JordanProtin Could you check that if you update _objectSpread2 like this in @babel/helpers, @babel/runtime, @babel/runtime-corejs2 and/or @babel/runtime-corejs3 in your node_modules (there could be multiple copied of each package) it works? I can reproduce the error without this fix but it seems to be fixed.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11076/

@existentialism
Copy link
Member

left a comment

😬

@JordanProtin

This comment has been minimized.

Copy link

commented Jul 9, 2019

@nicolo-ribaudo Thank you for your hard work ! I'm sorry, it's a difficult for me to test this now ! I'll do this ASAP ! :D

@nicolo-ribaudo nicolo-ribaudo merged commit 9e65472 into babel:master Jul 9, 2019

4 checks passed

babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 87.57% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:lol-fix branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.