Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipeline nodes to ast.spec #10214

Merged
merged 1 commit into from Jul 13, 2019
Merged

Conversation

@mAAdhaTTah
Copy link
Contributor

@mAAdhaTTah mAAdhaTTah commented Jul 13, 2019

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? N/A
Major: Breaking Change? N/A
Minor: New Feature? N/A
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Add the missing types in ast/spec.md, addressing the comment here.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Maybe we should add a note that f# uses simple BinaryExpressions?

@mAAdhaTTah
Copy link
Contributor Author

@mAAdhaTTah mAAdhaTTah commented Jul 13, 2019

@mAAdhaTTah mAAdhaTTah force-pushed the mAAdhaTTah:add-ast-to-docs branch from 6970a74 to 69a908a Jul 13, 2019
@thiagoarrais
Copy link
Contributor

@thiagoarrais thiagoarrais commented Jul 13, 2019

Nice work!

@nicolo-ribaudo nicolo-ribaudo merged commit 7f47cb6 into babel:master Jul 13, 2019
@lock lock bot added the outdated label Oct 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants