Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvent typeof transform for umd build template #10701

Merged
merged 3 commits into from Nov 13, 2019

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Nov 13, 2019

Q                       A
Fixed Issues? Fixes #10662
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

In this PR we revise the umd module build template to avoid typeof transforms. It is not an ideal fix as ultimately we should hoist helper declaration to the program block if referenced by any nodes in the build template.

On the other hand we may skip polyfilling the typeof calls in build template as it is rare to assign a symbol to these global properties.

This PR is a follow-up to #10477.

@JLHwung

This comment has been minimized.

Copy link
Contributor Author

JLHwung commented Nov 13, 2019

@langi93 Is that related to this PR?

@jridgewell

This comment has been minimized.

Copy link
Member

jridgewell commented Nov 13, 2019

It's a spam account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.