Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd main file for babel-node #10719
+6
−1
Conversation
3 commits
Nov 15, 2019
added
This comment has been minimized.
This comment has been minimized.
I'm conservative on this change as adding a Could |
This comment has been minimized.
This comment has been minimized.
Hey @JLHwung, bin special is in fact the special I'm using. This uses resolveFrom, which in turn uses require.resolve. Other options like resolve-bin also use require.resolve, so it always seems to come down to that :P. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dword-design commentedNov 15, 2019
It sometimes makes sense to
require.resolve
a package in order to look for certain information/files. E.g. https://www.npmjs.com/package/depcheck parses the binaries from packages in order to find out if it's an unused dependency. However, this requires the packages to have a main file. This PR simply addslib/babel-node.js
as the main fine.