Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preset-env mappings #10742

Merged
merged 1 commit into from Nov 20, 2019
Merged

Update preset-env mappings #10742

merged 1 commit into from Nov 20, 2019

Conversation

@existentialism
Copy link
Member

existentialism commented Nov 20, 2019

Q                       A
Fixed Issues? Fixes #10740
Patch: Bug Fix? Y
Major: Breaking Change? N
Minor: New Feature? N
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

After this, we can rebase #10225 and land that as well.

@@ -6,7 +6,7 @@
"safari": "10.1",
"opera": "48",
"ios_saf": "10.3",
"and_chr": "71",
"and_ff": "64"
"and_chr": "74",

This comment has been minimized.

Copy link
@JLHwung

JLHwung Nov 20, 2019

Contributor

I don't think we need to bump and_chr and and_ff because:

  1. CanIUse doesn't support mobile browsers versions
  2. caniuse-db is not bumped

This comment has been minimized.

Copy link
@existentialism

existentialism Nov 20, 2019

Author Member

CanIUse doesn't support mobile browsers versions

What do you mean? This data is generated directly via our script?

image

caniuse-db is not bumped

FWIW, if you run build-data on master, it updates these two values with the version of caniuse-db that it's pinned to. In fact, if we bump it, it'll update and_chr to 78.

This comment has been minimized.

Copy link
@JLHwung

JLHwung Nov 20, 2019

Contributor

They should not be updated because caniuse does not track old mobile browser versions, so and_chr will always return the latest version of all available Android Chrome, same as and_ff. (i.e. they are bumped in this commit of caniuse-db)

Could we skip and_ff and and_chr in

const skipList = new Set(["android", "samsung"]);

This comment has been minimized.

Copy link
@existentialism

existentialism Nov 20, 2019

Author Member

Oh, gotcha. Yep I'll make an update.

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Nov 20, 2019

Member

Related: #9978

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Nov 20, 2019

Member

According to #7344 (comment), it was you who explained it to me 😛

This comment has been minimized.

Copy link
@JLHwung

JLHwung Nov 20, 2019

Contributor

@nicolo-ribaudo Any idea why and_chr is removed from skipList in #9978?

This comment has been minimized.

Copy link
@existentialism

existentialism Nov 20, 2019

Author Member

Adding them to skipList would remove them from the generated output altogether

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Nov 20, 2019

Member

Yeah, and it doesn't really matter since browserlists returns the desktop version anyway.

This comment has been minimized.

Copy link
@JLHwung

JLHwung Nov 20, 2019

Contributor

Then we need a doNotUpdateList then. Anyway let's address it in a separate PR.

@existentialism existentialism force-pushed the issue-10740 branch from 0721da5 to 22d087d Nov 20, 2019
@JLHwung JLHwung merged commit 83fc3f2 into master Nov 20, 2019
5 of 6 checks passed
5 of 6 checks passed
test262 Workflow: test262
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 88.15% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
@JLHwung JLHwung deleted the issue-10740 branch Nov 20, 2019
@lock lock bot added the outdated label Feb 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.