Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename detection should respect short flags #10763

Merged
merged 3 commits into from Jan 11, 2020
Merged

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Nov 25, 2019

Q                       A
Fixed Issues? Fixes #9349
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Any Dependency Changes? Yes, commander is bumped to v4.0.1 to be consistent with babel-cli.
License MIT

In this PR we fixed the filename detection logic by respecting the short flags (e.g. -v) other than long flags --version. The previous ad-hoc approach is thus replaced by program.options API.

@JLHwung JLHwung force-pushed the JLHwung:fix-9349 branch from d5fa57a to ff09232 Dec 24, 2019
@JLHwung

This comment has been minimized.

Copy link
Contributor Author

JLHwung commented Jan 11, 2020

@JLHwung JLHwung merged commit 903ad61 into babel:master Jan 11, 2020
4 of 5 checks passed
4 of 5 checks passed
build (13.x)
Details
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:fix-9349 branch Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.