Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve error message in @babel/core #10778

Merged
merged 1 commit into from Nov 30, 2019

Conversation

jaroslav-kubicek
Copy link
Contributor

@jaroslav-kubicek jaroslav-kubicek commented Nov 29, 2019

Hi 馃憢

I would like to propose updating the error message when running babel with rootMode:"upward" so user gets feedback on what's expected.

Motivation:

Given I have a repository and I migrated recently to babel 7.x and still using just .babelrc for configuration. I ran a script provided to me by a third-party library which tried to search for my config but failed with this error. I would like to understand more about what is expected of me from an error message.

@JLHwung
Copy link
Contributor

JLHwung commented Nov 29, 2019

@jaroslav-kubicek Thanks for fixing the outdated test fixtures. I have cherry-picked your fix to the master branch. Could you rebase?

@nicolo-ribaudo nicolo-ribaudo added area: errors PR: Polish 馃拝 A type of pull request used for our changelog categories labels Nov 29, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 26c0a32 into babel:master Nov 30, 2019
@nicolo-ribaudo
Copy link
Member

Thanks!

@jaroslav-kubicek jaroslav-kubicek deleted the improve-error-message branch December 1, 2019 13:49
mrtnzlml added a commit to adeira/universe that referenced this pull request Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
mrtnzlml added a commit to adeira/universe that referenced this pull request Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
mrtnzlml added a commit to adeira/universe that referenced this pull request Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
adeira-github-bot pushed a commit to adeira/relay-example that referenced this pull request Dec 14, 2019
This feature was requested here adeira/universe#189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.

adeira-source-id: a7917273c3a7861fa3f355e38c9ab732a9b1d150
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 2, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 馃拝 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants