Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve error message in @babel/core #10778

Merged
merged 1 commit into from Nov 30, 2019

Conversation

@jaroslav-kubicek
Copy link
Contributor

jaroslav-kubicek commented Nov 29, 2019

Hi 馃憢

I would like to propose updating the error message when running babel with rootMode:"upward" so user gets feedback on what's expected.

Motivation:

Given I have a repository and I migrated recently to babel 7.x and still using just .babelrc for configuration. I ran a script provided to me by a third-party library which tried to search for my config but failed with this error. I would like to understand more about what is expected of me from an error message.

@JLHwung

This comment has been minimized.

Copy link
Contributor

JLHwung commented Nov 29, 2019

@jaroslav-kubicek Thanks for fixing the outdated test fixtures. I have cherry-picked your fix to the master branch. Could you rebase?

@jaroslav-kubicek jaroslav-kubicek force-pushed the jaroslav-kubicek:improve-error-message branch from 9d136b9 to 8da1b35 Nov 29, 2019
@jaroslav-kubicek jaroslav-kubicek force-pushed the jaroslav-kubicek:improve-error-message branch from 8da1b35 to 5b4c73f Nov 30, 2019
@nicolo-ribaudo nicolo-ribaudo merged commit 26c0a32 into babel:master Nov 30, 2019
4 of 5 checks passed
4 of 5 checks passed
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 88.14% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Nov 30, 2019

Thanks!

@jaroslav-kubicek jaroslav-kubicek deleted the jaroslav-kubicek:improve-error-message branch Dec 1, 2019
mrtnzlml added a commit to adeira/universe that referenced this pull request Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
mrtnzlml added a commit to adeira/universe that referenced this pull request Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
mrtnzlml added a commit to adeira/universe that referenced this pull request Dec 2, 2019
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
adeira-github-bot added a commit to adeira/relay-example that referenced this pull request Dec 14, 2019
This feature was requested here adeira/universe#189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.

adeira-source-id: a7917273c3a7861fa3f355e38c9ab732a9b1d150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.