New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle standalone using rollup #10779
Merged
JLHwung
merged 11 commits into
babel:master
from
JLHwung:standalone-rollup-bundle-without-yarn-workspaces
Dec 5, 2019
Merged
Bundle standalone using rollup #10779
JLHwung
merged 11 commits into
babel:master
from
JLHwung:standalone-rollup-bundle-without-yarn-workspaces
Dec 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e47930
to
5ba0487
Compare
JLHwung
commented
Nov 30, 2019
], | ||
sourceType: "unambiguous", | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are removed since rollup-plugin-babel
can combine the helpers into a single block.
nicolo-ribaudo
approved these changes
Dec 2, 2019
CircleCI is failing because of core-js 3.4.6. It's fixed in 3.4.7, but I don't know how to clear the cache before triggering a build. |
Co-authored-by: Daniel Tschinder <daniel.tschinder@researchgate.net>
# Conflicts: # yarn.lock
eedddce
to
5244a7b
Compare
existentialism
approved these changes
Dec 5, 2019
This was referenced Feb 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: standalone
PR: Internal 🏠
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
*-standalone
sizeThis PR supersedes #7581 and is loosely based on #7581 because I find it too difficult to rebase.
This PR translates the webpack config in the language of rollup config.
gulp-uglify
is also replaced byrollup-plugin-terser
.Updates:
There is a fatal error on the previous size comparison table, some of the dependencies of
babel-preset-env-standalone
was not bundled due to theimporter
is not an ES Module. The new size comparison has reflected on this fix. Thanks to @nicolo-ribaudo who fist discovered this error.Here is the size comparison between Circle CI Artifacts and
*-standalone
7.7.4 (babel, env)The increased size in
babel-preset-env.js
is from the fact that rollup does not strip the comments by default. For production usage, please refer tobabel-preset-env.min.js
.Here is the size comparison between [Circle CI Artifacts](https://app.circleci.com/jobs/github/babel/babel/13068) and `*-standalone` 7.7.4 ([babel](https://unpkg.com/browse/@babel/standalone@7.7.4/), [env](https://unpkg.com/browse/@babel/preset-env-standalone@7.7.4/))
Previous Size
New Size
Change
babel.js
3.04 MB
2.6 MB
14%
babel.min.js
1.63 MB
1.2 MB
26%
babel-preset-env.js
2.93 MB
1.0 MB
66%
babel-preset-env.min.js
1.7 MB
450 kB
74%
(It seems that
buildsize
does not comment for unknown reasons...)