Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune makefile scripts #10781

Merged
merged 5 commits into from Dec 5, 2019
Merged

Tune makefile scripts #10781

merged 5 commits into from Dec 5, 2019

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Nov 29, 2019

Q                       A
License MIT

In this PR we wrap node call into a yarn call so it can be future-proof on upcoming yarn 2 upgrade.

@JLHwung JLHwung requested a review from nicolo-ribaudo Nov 29, 2019
jestArgs="--coverage"

if [ -n "$CI" ]; then
jestArgs="${jestArgs} --maxWorkers=4 --ci"
fi

node_modules/.bin/jest $jestArgs
$node node_modules/.bin/jest $jestArgs

This comment has been minimized.

Copy link
@JLHwung

JLHwung Nov 29, 2019

Author Contributor

We leave jest to be relative path as we plan to unplug jest on yarn 2 so that it can work with --inspect-brk.

@JLHwung JLHwung force-pushed the JLHwung:tune-makefile-scripts branch from a5cf4c0 to f1b4c3c Nov 30, 2019
@JLHwung JLHwung force-pushed the JLHwung:tune-makefile-scripts branch from c734f18 to 46b831e Dec 5, 2019
@@ -14,6 +14,9 @@ EMPTY :=
SPACE := $(EMPTY) $(EMPTY)
COMMA_SEPARATED_SOURCES = $(subst $(SPACE),$(COMMA),$(SOURCES))

YARN := yarn --silent

This comment has been minimized.

Copy link
@JLHwung

JLHwung Dec 5, 2019

Author Contributor

This will suppress the yarn foo v1.2.3 header printed by yarn. I think it is okay to use $(YARN) when we use it to invoke another node binaries, e.g. eslint/prettier.

@JLHwung JLHwung merged commit 2b47291 into babel:master Dec 5, 2019
4 of 5 checks passed
4 of 5 checks passed
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 88.14% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
@JLHwung JLHwung deleted the JLHwung:tune-makefile-scripts branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.