Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tuple rest trailing comma #10800

Merged

Conversation

@yeonjuan
Copy link
Contributor

yeonjuan commented Dec 3, 2019

Q                       A
Fixed Issues? Fixes #10769
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
this.checkCommaAfterRest(charCodes.rightSquareBracket);
if (
this.match(tt.comma) &&
this.lookaheadCharCode() !== charCodes.rightSquareBracket

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Dec 3, 2019

Member

Is there already a test for when ...a, is not followed by ]?

This comment has been minimized.

Copy link
@yeonjuan

yeonjuan Dec 3, 2019

Author Contributor


@nicolo-ribaudo yes! in the tuple-rest-invalid.

@JLHwung
JLHwung approved these changes Dec 3, 2019
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 3, 2019

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit d18afbd into babel:master Dec 3, 2019
4 of 5 checks passed
4 of 5 checks passed
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 88.14% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.