Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scope flags to check arguments #10801

Merged
merged 2 commits into from Dec 5, 2019
Merged

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Dec 3, 2019

Q                       A
Fixed Issues? Fixes #10771
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

In this PR we introduce inClass accessor in ScopeHandler and use it to check arguments keyword. Please refer to this thread for the background.

JLHwung added 2 commits Dec 3, 2019
Co-authored-by: Jens Maier<jens@elberet.de>
Copy link
Member

nicolo-ribaudo left a comment

Can you add a test with arrow functions?

class A {
  x = () => arguments;
}
@nicolo-ribaudo nicolo-ribaudo merged commit c6e966c into babel:master Dec 5, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/project 88.14% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
test262 Workflow: test262
Details
@nicolo-ribaudo nicolo-ribaudo deleted the JLHwung:fix-10771 branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.