Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable optional chaining by default in @babel/parser #10817

wants to merge 19 commits into from


Copy link

jackisherwood commented Dec 5, 2019

Q                       A
Fixed Issues? Fixes #10810
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y
Tests Added + Pass? Y
Documentation PR Link
Any Dependency Changes?
License MIT
JLHwung approved these changes Dec 5, 2019

This comment has been minimized.

Copy link

existentialism commented Dec 5, 2019

@jackisherwood nice work!


This comment has been minimized.

Copy link

nicolo-ribaudo commented Dec 5, 2019

@jackisherwood FYI, this PR will take a while to be merged because we merge semver-minor PRs right before releasing.

* fix: promise.any requires global.AggregateError

* address review comments
ajafff and others added 10 commits Dec 28, 2019
* Dereference imported template tag

* apply fix for OptionalCallExpression as well
* chore: update test262

* chore: ignore untoggleable features
* chore: remove unused isStrictBody

* chore: remove unused eatRelational
* refactor: unify optionalMemberExpression generation

* test: add optional calls invalid typecasts

* fix: do not parse async arrow when call is optional

* test: update test fixtures

* refactor: remove unused invalidTemplateEscapePosition tokenizer state

* fix flow error
…ediate child (#10946)

* fix: scope.inAsync should exclude reference in class property initializers

* chore: add test on await in computed class property

* fix flow error :(
* Override toString in case this function is printed

Related to

* Don't override `toString` if `wrapper` is true

Override `toString` immediately before returning a newFn, otherwise it will be overridden if wrapper is true

#10949 (comment)

* prettier

This comment has been minimized.

Copy link

kaicataldo commented Jan 3, 2020

@jackisherwood Do you mind rebasing off of master and fixing the merge conflicts?

JLHwung added 5 commits Jan 3, 2020
* chore: add e2e-vue-cli test

* chore: add node-browsers-executor

* chore: state why node-browsers-executor is required
* test: add test on template

* fix: update lineStart when string contains U+2028/U+2029
* test: add lone import test

* polish: raise recoverable error

This comment has been minimized.

Copy link
Contributor Author

jackisherwood commented Jan 3, 2020

@kaicataldo Done :)

nicolo-ribaudo added a commit that referenced this pull request Jan 10, 2020

This comment has been minimized.

Copy link

nicolo-ribaudo commented Jan 10, 2020

Merged at 5f807ae


This comment has been minimized.

Copy link

Lvjiangsheng commented on .circleci/config.yml in e504805 Jan 28, 2020

OMG I don't kown nothing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.