Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullish coalescing by default in @babel/parser #10819

Merged
merged 2 commits into from Jan 10, 2020

Conversation

@layershifter
Copy link
Contributor

layershifter commented Dec 5, 2019

Q                       A
Fixed Issues? Fixes #10813
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature? Y
Tests Added + Pass? Y
Documentation PR Link
Any Dependency Changes?
License MIT
@layershifter

This comment has been minimized.

Copy link
Contributor Author

layershifter commented Dec 5, 2019

Hey folks, do you have any ideas why CI fails on this test? 🤔

 FAIL  packages/babel-preset-env/test/targets-parser.spec.js
  ● getTargets › allows 'defaults' query

    expect(received).toEqual(expected) // deep equality

    - Expected
    + Received

      Object {
    -   "android": "77.0.0",
    +   "android": "76.0.0",
        "chrome": "49.0.0",
        "edge": "17.0.0",
        "firefox": "68.0.0",
        "ie": "11.0.0",
        "ios": "12.2.0",
    -   "opera": "63.0.0",
    +   "opera": "46.0.0",
        "safari": "5.1.0",
        "samsung": "9.2.0",
      }

const browsers = browserslist(browsersquery, {
path: options.configPath,
mobileToDesktop: true,
});

If I will set mobileToDesktop: false, it passes. I have the same issue on master and it looks that there is a collision in browserNameMap:

  op_mob: "opera",
  opera: "opera",

But I don't understand how it's related to my changes 🤔

@JLHwung

This comment has been minimized.

Copy link
Contributor

JLHwung commented Dec 5, 2019

@layershifter The CI error is unrelated to your changes, it comes from recent browserslist 4.8.1 update, I will fix it in another PR.

@nicolo-ribaudo nicolo-ribaudo force-pushed the layershifter:chore/move-nullish-plugin branch from 4a8b9b2 to 62b5e8d Jan 10, 2020
@nicolo-ribaudo nicolo-ribaudo force-pushed the layershifter:chore/move-nullish-plugin branch from 62b5e8d to d974754 Jan 10, 2020
@nicolo-ribaudo nicolo-ribaudo force-pushed the layershifter:chore/move-nullish-plugin branch from d974754 to 08dfe68 Jan 10, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit c3388ea into babel:master Jan 10, 2020
3 of 5 checks passed
3 of 5 checks passed
build (13.x)
Details
Travis CI - Pull Request Build Errored
Details
test262 Workflow: test262
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.