Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive syntax plugins enabled by default #10820

Merged
merged 4 commits into from Jan 12, 2020

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 5, 2019

Q                       A
License MIT

Moved to babel-archive: babel/babel-archive@8f23ddc

  • @babel/plugin-syntax-async-generators
  • @babel/plugin-syntax-bigint
  • @babel/plugin-syntax-dynamic-import
  • @babel/plugin-syntax-json-strings
  • @babel/plugin-syntax-nullish-coalescing-operator
  • @babel/plugin-syntax-object-rest-spread
  • @babel/plugin-syntax-optional-catch-binding
  • @babel/plugin-syntax-optional-chaining
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 6, 2019

This PR depends on all the PRs that are enabling some syntax by default in the parser

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:syntax-default-archived branch 4 times, most recently from 30899e7 to b15ccff Jan 10, 2020
@nicolo-ribaudo nicolo-ribaudo changed the title Remove syntax plugins enabled by default Archive syntax plugins enabled by default Jan 10, 2020
Moved to babel-archive: babel/babel-archive@8f23ddc

- `@babel/plugin-syntax-async-generators`
- `@babel/plugin-syntax-bigint`
- `@babel/plugin-syntax-dynamic-import`
- `@babel/plugin-syntax-json-strings`
- `@babel/plugin-syntax-nullish-coalescing-operator`
- `@babel/plugin-syntax-object-rest-spread`
- `@babel/plugin-syntax-optional-catch-binding`
- `@babel/plugin-syntax-optional-chaining`
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:syntax-default-archived branch from b15ccff to cb1b272 Jan 12, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit a677d59 into babel:master Jan 12, 2020
2 of 5 checks passed
2 of 5 checks passed
build (13.x)
Details
Travis CI - Pull Request Build Errored
Details
e2e Workflow: e2e
Details
test262 Workflow: test262
Details
build-standalone Workflow: build-standalone
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:syntax-default-archived branch Jan 12, 2020
@Alonski

This comment has been minimized.

Copy link

Alonski commented Jan 14, 2020

Hmm wondering why this wasn't a breaking change. 🤔
Had to install all of these one by one until build passed

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Jan 14, 2020

With Babel 7.8 you don't need to install them. Maybe you were accidentally using an older Babel version, which required them.

Can you share a repository which reproduces the issue?

@Alonski

This comment has been minimized.

Copy link

Alonski commented Jan 14, 2020

Hmm it is on a private app that I can't share. I just upgraded from 7.8.0 to 7.8.3 and started seeing compile time errors. Weird I know :)

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Jan 14, 2020

Also, this PR only changes tests and moves some packages to a different repository. It doesn't change the contents of any published package 🤔

@Alonski

This comment has been minimized.

Copy link

Alonski commented Jan 14, 2020

Hmm maybe it's not this PR then. 😅 I'll check again tomorrow and jump minors one by one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.