Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] enable dynamic import by default #10843

Merged
merged 2 commits into from Jan 10, 2020

Conversation

@AbdulAli19
Copy link
Contributor

AbdulAli19 commented Dec 9, 2019

Q                       A
Fixed Issues? Fixes #10824
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? No
Documentation PR Link
Any Dependency Changes? No
License MIT
@AbdulAli19

This comment has been minimized.

Copy link
Contributor Author

AbdulAli19 commented Dec 9, 2019

couldn't get tests to pass locally so i figure i'm missing something. thought i'd create this pr anyway to get feedback/help on what that might be.

edit: the tests that are failing in ci are different than what i was seeing locally, going to see to if i can fix the ones that are failing in ci

@AbdulAli19 AbdulAli19 force-pushed the AbdulAli19:dynamic-import-default branch from 26b890c to a41b2e2 Dec 9, 2019
@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Dec 9, 2019
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 9, 2019

The babel-preset-env/ failing test is not caused by this PR.
Also, the /es2020/dynamic-import/no-plugin/input.js and experimental/_no plugin/dynamic import/* files can be deleted.

@AbdulAli19

This comment has been minimized.

Copy link
Contributor Author

AbdulAli19 commented Dec 9, 2019

Also, the /es2020/dynamic-import/no-plugin/input.js file can be deleted.

can i also get rid of /experimental/_no-plugin/dynamic-import/input.js?

@AbdulAli19 AbdulAli19 force-pushed the AbdulAli19:dynamic-import-default branch from a41b2e2 to baceca9 Dec 9, 2019
@AbdulAli19

This comment has been minimized.

Copy link
Contributor Author

AbdulAli19 commented Dec 9, 2019

the babel-preset-env/ test is the only failing test now. thanks for the help, @nicolo-ribaudo!

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 9, 2019

Rebasing on master should make the tests pass

@AbdulAli19 AbdulAli19 force-pushed the AbdulAli19:dynamic-import-default branch from baceca9 to b2fd90b Dec 10, 2019
Copy link
Member

existentialism left a comment

👍 @AbdulAli19 nice work!

@nicolo-ribaudo nicolo-ribaudo merged commit 5b907e9 into babel:master Jan 10, 2020
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Pull Request Build Failed
Details
test262 Workflow: test262
Details
codecov/project 88.15% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.