Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify package type [skip-ci] #10849

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Dec 9, 2019

Q                       A
License MIT

Per Node.js ECMAScript Modules Docs, package should include "type" field and be explicit about it.

Copy link
Member

nicolo-ribaudo left a comment

I'm really looking forward to Yarn 2 when we'll be able to use https://next.yarnpkg.com/features/constraints

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 9, 2019

While this PR doesn't add any new feature, I would prefer to merge it in v7.8.0. Since it changes every package, it will cause every package of the monorepo to be published even if the code is the same.
I think that we should keep patch releases small.

@JLHwung

This comment has been minimized.

Copy link
Contributor Author

JLHwung commented Dec 9, 2019

@nicolo-ribaudo I am also going to add exports: false to every package (other than @babel/runtime). I can prepend exports: false to "licence": "MIT" so that we can avoid merge conflicts, though.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.8.0 milestone Dec 9, 2019
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 9, 2019

Since this PR is quite simple, you push the exports changes here as a separate commit and then we'll use "Rebase and merge" instead of "Squash and merge" if you prefer.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 20, 2019

I have added the Ready to be Merged label even if there is a single review, since this PR is quite straightforward.

@JLHwung JLHwung merged commit e8dac62 into babel:master Jan 10, 2020
4 of 5 checks passed
4 of 5 checks passed
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 88.15% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
@JLHwung JLHwung deleted the JLHwung:add-type-commonjs branch Jan 10, 2020
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jan 13, 2020
This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
nicolo-ribaudo added a commit that referenced this pull request Jan 13, 2020
This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.