Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lost leading comment after named import #10901

Merged
merged 5 commits into from Dec 22, 2019
Merged

Conversation

@elevatebart
Copy link
Contributor

elevatebart commented Dec 20, 2019

Q                       A
Fixed Issues? Fixes #10892
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT
elevatebart added 2 commits Dec 20, 2019
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Dec 20, 2019

@elevatebart If needed, you can ping us to restart the build 😉

@nicolo-ribaudo nicolo-ribaudo self-requested a review Dec 20, 2019
@elevatebart

This comment has been minimized.

Copy link
Contributor Author

elevatebart commented Dec 22, 2019

Ping @JLHwung, when you have min, would you tell me what you think?

Thank you again

@JLHwung

This comment has been minimized.

Copy link
Contributor

JLHwung commented Dec 22, 2019

@elevatebart Looks good to me, thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit f651f22 into babel:master Dec 22, 2019
5 checks passed
5 checks passed
Travis CI - Pull Request Build Passed
Details
codecov/project 88.18% (target 80%)
Details
e2e Workflow: e2e
Details
test Workflow: test
Details
test262 Workflow: test262
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.