Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Promise.any requires global.AggregateError #10930

Merged
merged 2 commits into from Dec 27, 2019

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Dec 26, 2019

Q                       A
Fixed Issues? Fixes #10910
Patch: Bug Fix? Yes
Tests Added + Pass? Nope
License MIT

C.f. zloirock/core-js#737 (comment)

@@ -358,7 +363,7 @@ export const StaticProperties: ObjectMap<ObjectMap<string | string[]>> = {
"esnext.promise.all-settled",
...PromiseDependenciesWithIterators,
],
any: ["esnext.promise.any", ...PromiseDependenciesWithIterators],
any: ["esnext.promise.any", ...PromiseAnyDependencies],

This comment has been minimized.

Copy link
@zloirock

zloirock Dec 27, 2019

Member

I think that it would be better just add esnext.aggregate-error to this line since at this moment it's used only here and I have no ideas wherePromiseAnyDependencies can be used in the future.

This comment has been minimized.

Copy link
@JLHwung

JLHwung Dec 27, 2019

Author Contributor

Can do. I thought it was some unwritten code convention that almost every entry is written as [name, ...depedencies].

@JLHwung JLHwung merged commit e9dc74e into babel:master Dec 27, 2019
3 of 5 checks passed
3 of 5 checks passed
build (13.x)
Details
Travis CI - Pull Request Build Errored
Details
test262 Workflow: test262
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:fix-corejs-promise-any-dependencies branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.