Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiteralPropertyName should allow BigIntLiteral #10955

Merged

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jan 3, 2020

Q                       A
Fixed Issues? LiteralPropertyName does not allow BigIntLiteral
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

Tracing through the spec:

LiteralPropertyName => NumericLiteral => DecimalBigIntegerLiteral
LiteralPropertyName => NumericLiteral => NonDecimalIntegerLiteral BigIntLiteralSuffix

Related:
tc39/test262#2457
https://bugs.chromium.org/p/v8/issues/detail?id=10083

CI is red due to

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jan 3, 2020

You can run make test-typescript-update-whitelist

Copy link
Member

nicolo-ribaudo left a comment

FWIW, I don't like this 🙃

@JLHwung

This comment has been minimized.

Copy link
Contributor Author

JLHwung commented Jan 4, 2020

Yeah we can always revert the whitelist when TypeScript fixed this issue.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jan 4, 2020

Oh, I meant the fact that JS allows bigints as property names 😂

@JLHwung

This comment has been minimized.

Copy link
Contributor Author

JLHwung commented Jan 4, 2020

@nicolo-ribaudo Well it has been staged 4, so 🤷‍♂️

Copy link
Member

kaicataldo left a comment

Huh, yeah, curious what the reasoning behind allowing this is. I guess since BigInts can already be values, it's not really making it harder to serialize objects.

@JLHwung JLHwung merged commit 8fd532d into babel:master Jan 7, 2020
4 of 5 checks passed
4 of 5 checks passed
build (13.x)
Details
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:property-name-should-allow-bigint-literal branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.