Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive @babel/preset-env-standalone #10993

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 12, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This package shouldn't be used anymore after #10821.

⚠️ This PR shouldn't be merged until the REPL supports not loading @babel/preset-env-standalone from CircleCI artifacts.


Depends on babel/website#2157 The REPL has problems even without merging this PR.

@nicolo-ribaudo nicolo-ribaudo changed the title Archive babel preset env standalone Archive @babel/preset-env-standalone Jan 12, 2020
@JLHwung

This comment has been minimized.

Copy link
Contributor

JLHwung commented Jan 13, 2020

until the REPL supports not loading @babel/preset-env-standalone from CircleCI artifacts.

Note that REPL still needs to load preset-env-standalone for older versions than 7.8.0. I suggest we preserve its backward compatibility to 7.0.0 until, I don't know, maybe 2021.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Jan 13, 2020

Yes, but I think that we should check the version. If <7.8.0 then load the second file, otherwise don't.

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:archive-babel-preset-env-standalone branch from a6f9eaf to 86a6a9c Jan 13, 2020
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:archive-babel-preset-env-standalone branch from 7781620 to 934f51f Feb 1, 2020
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:archive-babel-preset-env-standalone branch from 934f51f to 6419d59 Feb 1, 2020
It's already in babel-standalone/test/babel.js
@JLHwung
JLHwung approved these changes Feb 1, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 755ec19 into babel:master Feb 6, 2020
4 of 5 checks passed
4 of 5 checks passed
build (13.x)
Details
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:archive-babel-preset-env-standalone branch Feb 6, 2020
rajasekarm added a commit to rajasekarm/babel that referenced this pull request Feb 17, 2020
* Move @babel/preset-env-standalone to babel-archive

babel/babel-archive@a1fadd2

* Move tests to @babel/standalone

* Remove references in build scripts

* Update lockfile

* Delete duplicated test file.

It's already in babel-standalone/test/babel.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.