Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: specify package type (#10849)" #11003

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 13, 2020

Q                       A
Fixed Issues? Fixes #11000
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)

We should re-apply the reverted commit in Babel 8.0.0.

NOTE FOR MYSELF:
When publishing, also re-publish the packages moved to babel-archive

This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
@JLHwung

This comment has been minimized.

Copy link
Contributor

JLHwung commented Jan 13, 2020

🤔Maybe we need npm install and yarn install in e2e-babel.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Jan 13, 2020

It wouldn't have caught it, because we don't run e2e tests with Node 6.

@nicolo-ribaudo nicolo-ribaudo merged commit 8fce431 into babel:master Jan 13, 2020
4 of 5 checks passed
4 of 5 checks passed
build (13.x)
Details
test262 Workflow: test262
Details
Travis CI - Pull Request Build Passed
Details
build-standalone Workflow: build-standalone
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:revert-type-commonjs branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.