Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: specify package type (#10849)" #11003

Merged
merged 1 commit into from Jan 13, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 13, 2020

Q                       A
Fixed Issues? Fixes #11000
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)

We should re-apply the reverted commit in Babel 8.0.0.

NOTE FOR MYSELF:
When publishing, also re-publish the packages moved to babel-archive

This reverts commit e8dac62.

Fixes installs when using npm <= 3.9.5 (Node.js <= 6.2.2)
@nicolo-ribaudo nicolo-ribaudo added i: regression PR: Revert ↩️ labels Jan 13, 2020
@nicolo-ribaudo nicolo-ribaudo requested a review from JLHwung Jan 13, 2020
@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 13, 2020

🤔Maybe we need npm install and yarn install in e2e-babel.

@nicolo-ribaudo
Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo commented Jan 13, 2020

It wouldn't have caught it, because we don't run e2e tests with Node 6.

@nicolo-ribaudo nicolo-ribaudo merged commit 8fce431 into babel:master Jan 13, 2020
4 of 5 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the revert-type-commonjs branch Jan 13, 2020
@github-actions github-actions bot added the outdated label Apr 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated PR: Revert ↩️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants