Mark wrapNativeSuper and wrapRegExp as pure
#11134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
JLHwung
reviewed
Feb 13, 2020
| : t.cloneNode(superName); | ||
| let arg = t.cloneNode(superName); | ||
| if (classState.extendsNative) { | ||
| arg = t.callExpression(classState.file.addHelper("wrapNativeSuper"), [ |
There was a problem hiding this comment.
Can we add pure notation to the helper sources so we don't worry about if the helper needs pure annotation when added?
There was a problem hiding this comment.
I have thought about it, but the problem is that the annotation should be added to the CallExpression, and the æddHelper function only returns the callee.
nicolo-ribaudo
force-pushed
the
pure-helpers
branch
from
2e14276
to
b1b69e4
Compare
JLHwung
approved these changes
Feb 13, 2020
existentialism
approved these changes
Feb 21, 2020
kaicataldo
approved these changes
Feb 21, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically there are also other pure helpers (e.g.
asyncToGenerator), but annotating them won't help minifiers because their result is always directly used by the compiled output.