Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing edge cases in Nullish Coalescing and Optional Chaining #11255

Merged
merged 1 commit into from Mar 13, 2020

Conversation

jridgewell
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is a mix of changes, most importantly:

Also, cleans up a bit of code, and removes an unnecessary parens around class A extends new B {}

This is a mix of changes, most importantly:

- Always print parens when mixing nullish coalescing and another logical
- Fixes assignment in the callee of an optional chain, which now blocks babel#11248

Also, cleans up a bit of code, and removes an unnecessary parens around `class A extends new B {}`
@jridgewell jridgewell added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Mar 13, 2020
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is unrelated and would be fixed by rebasing.

@nicolo-ribaudo nicolo-ribaudo merged commit b1a589f into babel:master Mar 13, 2020
@jridgewell jridgewell deleted the babel-gen-fixes branch March 13, 2020 17:42
davecardwell added a commit to davecardwell/publix-coupon-clipper that referenced this pull request Mar 23, 2020
Includes babel/babel#11255 “Fix printing edge cases in Nullish
Coalescing and Optional Chaining” which changes our index.node.js
output.
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants