Add test for changing name of _typeof helper (for @babel/plugin-transform-typeof-symbol)

[yukihirop]

Q	A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

Summary

The name of the helper changes from _typeof to _typeof2 .

• When the function name in the function declaration is is _typeof
• When the variable name of the function expression is _typeof
• When the function name of the function expression is _typeof

So I add tests about it.

Bebel REPL ↓↓

Test

#~/JavaScriptProjects/babel (add_test_about-transform-typeof-symbol)
$ TEST_ONLY=babel-plugin-transform-typeof-symbol make test
BABEL_ENV=test yarn --silent eslint scripts packages codemods eslint '*.js' --format=codeframe
scripts/lint-ts-typings.sh
BABEL_ENV=test ./scripts/test.sh
 PASS  packages/babel-plugin-transform-typeof-symbol/test/helper.spec.js
 PASS  packages/babel-plugin-transform-typeof-symbol/test/index.js

Test Suites: 2 passed, 2 total
Tests:       14 passed, 14 total
Snapshots:   0 total
Time:        4.024s
Ran all test suites matching /(packages|codemods|eslint)\/.*babel-plugin-transform-typeof-symbol.*\/test/i.
/Applications/Xcode.app/Contents/Developer/usr/bin/make test-clean
rm -rf  packages/*/test/tmp
rm -rf  packages/*/test-fixtures.json
rm -rf  codemods/*/test/tmp
rm -rf  codemods/*/test-fixtures.json
rm -rf  eslint/*/test/tmp
rm -rf  eslint/*/test-fixtures.json

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24489/

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0565c09:

Sandbox	Source
serene-galileo-m9g4l	Configuration
cranky-keller-bvt9p	Configuration

[JLHwung]

The behaviour is rooted from generateUid:

babel/packages/babel-traverse/src/scope/index.js

Lines 375 to 376 in 3d498d0

	uid = this._generateUid(name, i);
	i++;

and tested in

babel/packages/babel-traverse/test/scope.js

Line 310 in 3d498d0

test("generateUid collision check after re-crawling", function () {

I don't think we have specificial-cased _typeof in our codebase so I am afraid test on _typeof here is not of much value.

[yukihirop]

@JLHwung

Thank you for review 🙇‍♂️

I learned a lot.