Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on initial TS4 catch param support #11767

Merged
merged 3 commits into from Jun 30, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jun 30, 2020

Q                       A
Fixed Issues? The generator does not support catch param types
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR fixes a bug in previous AST design #11755 where type: string is replaced by a TypeAnnotation AST Node. By doing so the transformer support is out of box.

This PR also adds generator support for catch param types.

@JLHwung JLHwung added this to the 7.11.0 milestone Jun 30, 2020
@JLHwung JLHwung requested a review from existentialism Jun 30, 2020
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jun 30, 2020
4 of 4 tasks complete
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 30, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24960/

@codesandbox
Copy link

codesandbox bot commented Jun 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 011458a:

Sandbox Source
winter-dew-znqle Configuration
nifty-jones-ipqdr Configuration
Copy link
Member

nicolo-ribaudo left a comment

Whooops 🙃
Thanks for catching this!

@existentialism
Copy link
Member

existentialism commented Jun 30, 2020

🤦‍♂️

@JLHwung JLHwung merged commit cefa136 into babel:feat-7.11.0/ts-4.0 Jun 30, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.85% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:ts4-catch-param branch Jun 30, 2020
nicolo-ribaudo added a commit that referenced this pull request Jul 15, 2020
* refactor: align with AST shape convention

* feat: print catch param type annotations

* test: add test case on transform
JLHwung added a commit that referenced this pull request Jul 29, 2020
* refactor: align with AST shape convention

* feat: print catch param type annotations

* test: add test case on transform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.