Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build standalone once in prepublish step #11777

Merged
merged 1 commit into from Jul 30, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jul 1, 2020

Q                       A
Fixed Issues? Removed duplicate build-standalone step in make publish
License MIT

Currently when make prepublish runs, @babel/standalone will be built twice

  1. make prepublish => make build => make build-standalone
  2. npm run-script prepublishOnly => make prepublish-build-standalone

The first step skips minification while the second one includes it. This PR removes the scripts hook in @babel/standalone and run prepublish-build-standalone when prepublish recipe is executed.

@codesandbox
Copy link

codesandbox bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f07ad4b:

Sandbox Source
stupefied-haibt-z7ses Configuration
beautiful-sound-1hcp2 Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 1, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25051/

@JLHwung JLHwung force-pushed the JLHwung:build-minified-standalone-prepublish branch from c92064e to f07ad4b Jul 1, 2020
@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 30, 2020

As we can see in https://app.circleci.com/pipelines/github/babel/babel/3237/workflows/0018a857-7362-4563-a44e-6da6443c9d07/jobs/25052 that the published @babel/standalone contains both minified and raw versions. This behaviour is not changed.

@JLHwung JLHwung merged commit 0e4cf1e into babel:main Jul 30, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.85% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:build-minified-standalone-prepublish branch Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.