Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-traverse: prefer clearer, reduced-bias option naming #11791

Merged

Conversation

@jayaddison
Copy link
Contributor

jayaddison commented Jul 4, 2020

Q                       A
Patch: Bug Fix? No
Major: Breaking Change? Yes
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link This babel-traverse option appears undocumented currently
Any Dependency Changes? No
License MIT

This proposed change attempts to clarify the naming of a babel-traverse option (noticed during development of #11790) by using language that aims to be clearer for non-native English speakers and has reduced modern connotations of bias.

Since the option doesn't appear to be widely used (ref) and doesn't appear to be documented(ref, ref), this changeset doesn't attempt to maintain backwards compatibility, although a release note to indicate that it is a breaking change would be useful.

@codesandbox
Copy link

codesandbox bot commented Jul 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9dc946d:

Sandbox Source
babel-repl-custom-plugin Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 4, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25413/

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Copy link
Member

kaicataldo left a comment

LGTM!

@JLHwung
JLHwung approved these changes Jul 6, 2020
Copy link
Contributor

JLHwung left a comment

Thanks.

@JLHwung JLHwung added this to the 7.11.0 milestone Jul 6, 2020
@JLHwung JLHwung merged commit 9daa50e into babel:main Jul 29, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.86% (target 90.00%)
Details
e2e Workflow: e2e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.