Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use repository HEAD when pulling third party repos #11837

merged 1 commit into from Jul 14, 2020


Copy link

JLHwung commented Jul 14, 2020

Q                       A
License MIT

The test262 is planning to rename master into main. In this PR we removes the --branch option when cloning third-party repos. By doing so git will always clone the repository HEAD, which is the default branch HEAD as of GitHub repos -- so we are agnostic about upstream default branch name.

@@ -88,7 +88,7 @@ jobs:
- run:
name: Setup Test Runner
command: |
git clone --recurse-submodules
git clone --depth=1 --recurse-submodules

This comment has been minimized.


JLHwung Jul 14, 2020 Author Contributor

Note that --depth=N implies --single-branch.

git clone --branch=gh-pages --single-branch --shallow-since=2020-04-01 build/compat-table
cd build/compat-table && git checkout -qf $COMPAT_TABLE_COMMIT
git clone --single-branch --shallow-since=2020-04-01 build/compat-table
cd build/compat-table && git checkout -q $COMPAT_TABLE_COMMIT

This comment has been minimized.


JLHwung Jul 14, 2020 Author Contributor

-f is to suppress warning when working tree is different than HEAD. This is highly unlikely since we have removed build/compat-table before cloning.

Copy link

babel-bot commented Jul 14, 2020

Build successful! You can test your changes in the REPL here:

Copy link

codesandbox bot commented Jul 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 683ab0d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@JLHwung JLHwung merged commit 7eaf37e into babel:main Jul 14, 2020
8 of 9 checks passed
8 of 9 checks passed
test262-pr Workflow: test262-pr
Gitpod Open an online workspace in Gitpod
Travis CI - Pull Request Build Passed
babel/repl REPL preview is available
build-standalone Workflow: build-standalone
ci/codesandbox Building packages succeeded.
codecov/project 91.85% (target 90.00%)
e2e Workflow: e2e
@JLHwung JLHwung deleted the JLHwung:use-repository-head-for-external-deps branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.