Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly set innerEndPos in CoverParenthesizedExpressionAndArrowParameterList #11847

Merged
merged 1 commit into from Jul 16, 2020

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jul 16, 2020

Q                       A
Fixed Issues? Fixes #10436
Patch: Bug Fix? Yes
License MIT

The lastTokEnd points to the last non-whitespace position of the last element of a sequence expression, which is also used in finishNode.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 16, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26042/

@codesandbox
Copy link

codesandbox bot commented Jul 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7462cf7:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@hzoo
hzoo approved these changes Jul 16, 2020
@existentialism existentialism merged commit f4eeff9 into babel:main Jul 16, 2020
7 of 8 checks passed
7 of 8 checks passed
build build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
e2e Workflow: e2e
Details
@existentialism existentialism deleted the JLHwung:fix-10436 branch Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.