Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable numericSeparator parsing support #11863


Copy link

JLHwung commented Jul 21, 2020

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
License MIT

This PR enables numericSeparator parsing support in @babel/parser.

Note that this PR targets to a feature branch feat-7.11.0/stage-4, it can be merged if we can have two approval.

Copy link

codesandbox bot commented Jul 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fec8fe:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@JLHwung JLHwung mentioned this pull request Jul 21, 2020
5 of 5 tasks complete
Copy link

babel-bot commented Jul 21, 2020

Build successful! You can test your changes in the REPL here:

@nicolo-ribaudo nicolo-ribaudo merged commit 475c397 into babel:feat-7.11.0/stage-4 Jul 22, 2020
8 of 9 checks passed
8 of 9 checks passed
test262-pr Workflow: test262-pr
Gitpod Open an online workspace in Gitpod
Travis CI - Pull Request Build Passed
babel/repl REPL preview is available
build-standalone Workflow: build-standalone
ci/codesandbox Building packages succeeded.
codecov/project 91.85% (target 90.00%)
e2e Workflow: e2e
@nicolo-ribaudo nicolo-ribaudo deleted the JLHwung:enable-numeric-separator-parsing branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.