Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `numeric-separator` to `preset-env` #11865

Merged

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jul 21, 2020

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
License MIT

numeric-separator was added to preset-env in #10971 but behind shippedProposals flag. This PR moves the proposal to es2021 feature sets.

@JLHwung JLHwung mentioned this pull request Jul 21, 2020
5 of 5 tasks complete
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 21, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26274/

@codesandbox
Copy link

codesandbox bot commented Jul 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e3b41da:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@nicolo-ribaudo nicolo-ribaudo added this to the 7.11.0 milestone Jul 22, 2020
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 22, 2020

Oh I didn't notice the feature branch

@nicolo-ribaudo nicolo-ribaudo merged commit 8f3f175 into babel:feat-7.11.0/stage-4 Jul 22, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.85% (target 90.00%)
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the JLHwung:numeric-separator-preset-env branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.