Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logical assignment in babel preset env #11876

Merged
merged 3 commits into from Jul 29, 2020

Conversation

@morrme
Copy link
Contributor

morrme commented Jul 26, 2020

Q                       A
Fixed Issues? Fixes #11861
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link n/a
Any Dependency Changes? No
License MIT

@codesandbox
Copy link

codesandbox bot commented Jul 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcc17b4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
Copy link
Contributor

JLHwung left a comment

Can you update the test fixtures?
You can run

OVERWRITE=true yarn jest
@morrme
Copy link
Contributor Author

morrme commented Jul 28, 2020

Can you update the test fixtures?
You can run

OVERWRITE=true yarn jest

yarn seems to be giving me errors, I will see if I can sort them out to make this work.

@JLHwung JLHwung mentioned this pull request Jul 29, 2020
5 of 5 tasks complete
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 29, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26513/

@@ -21,6 +21,7 @@
"samsung": "11",
"electron": "6"
},
"proposal-logical-assignment-operators": {},

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo Jul 29, 2020 Member

Note (not in this PR): we probably need to update compat-table

@nicolo-ribaudo nicolo-ribaudo merged commit 333e714 into babel:feat-7.11.0/stage-4 Jul 29, 2020
7 of 8 checks passed
7 of 8 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.85% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung mentioned this pull request Jul 29, 2020
@existentialism
Copy link
Member

existentialism commented Jul 29, 2020

@morrme thanks!

JLHwung added a commit that referenced this pull request Jul 29, 2020
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.