Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect module path when absoluteRuntime is specified #11893

Merged
merged 5 commits into from Jul 30, 2020

Conversation

@sz-coder
Copy link
Contributor

sz-coder commented Jul 29, 2020

Q                       A
Fixed Issues? Fixes #11885
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Changed moduleName to modulePath in packages/plugin-transform-runtime/src/index.js.

sz-coder added 2 commits Jul 29, 2020
…rejs3.
Copy link
Contributor

JLHwung left a comment

Good catch! Looks good to me with some nits.

@codesandbox
Copy link

codesandbox bot commented Jul 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 433c55d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@JLHwung JLHwung changed the title Fix issue 11885 Fix incorrect module path when absoluteRuntime is specified Jul 29, 2020
@sz-coder
Copy link
Contributor Author

sz-coder commented Jul 29, 2020

Do I have to change anything or are these changes applied automatically?

Sorry I'm not familiar with GitHub Pull Requests.

@JLHwung
Copy link
Contributor

JLHwung commented Jul 29, 2020

@sz-coder They can be applied from GUI, however we still have to manually update the test fixtures:

OVERWRITE=true yarn jest transform-runtime
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 29, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26646/

@hzoo
hzoo approved these changes Jul 29, 2020
@@ -35,6 +35,7 @@
"@babel/plugin-transform-typeof-symbol": "^7.10.4",
"@babel/preset-env": "^7.10.4",
"@babel/runtime": "^7.10.5",
"@babel/runtime-corejs3": "^7.10.5",

This comment has been minimized.

@JLHwung

JLHwung Jul 30, 2020 Contributor

This is meant to fix the e2e error: https://app.circleci.com/pipelines/github/babel/babel/3524/workflows/90153e91-f615-4930-8a0f-5ed243d3a6cc/jobs/26605/parallel-runs/0/steps/0-103

The error is thrown because @babel/runtime-corejs3 is not hoisted to the top level in e2e-test. The other test is passing because @babel/runtime-corejs3 is hoisted to the top level from fixture locations, this is not guaranteed and dev deps should be declared.

This comment has been minimized.

@sz-coder

sz-coder Jul 30, 2020 Author Contributor

Thanks!

@JLHwung JLHwung merged commit 4ce1b70 into babel:main Jul 30, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.62% (target 90.00%)
Details
e2e Workflow: e2e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.