Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to publish `@babel/eslint-*` packages #11894

Merged
merged 5 commits into from Jul 30, 2020
Merged

Conversation

@JLHwung
Copy link
Contributor

JLHwung commented Jul 29, 2020

Q                       A
Fixed issue Closes #10709, resolves babel/babel-eslint#787
Any Dependency Changes? Bump node requirements of @babel/eslint-* packages.
License MIT

This PR includes preparations need to publish @babel/eslint-* packages. It includes commits in #11857, I will rebase once that PR gets merged.

Some noticeable changes compared to #11857:

  • Require node to be ^10.13.0 || ^12.13.0 || >=14.0.0. It covers only supported node versions as of July 2020
  • Disable submodule exports
  • Require babel to be >=7.11.0 since it is the Babel version that these packages are tested against

Note that @babel/eslint-shared-fixtures and @babel/eslint-tests are still private packages. I can not think of any use case of them and they looks to me more like a side-effect of sharing internal utils across different packages in a monorepo.

@JLHwung JLHwung added this to the 7.11.0 milestone Jul 29, 2020
@@ -15,12 +14,17 @@
},
"homepage": "https://babeljs.io/",
"engines": {
"node": ">=10.9"
"node": "^10.13.0 || ^12.13.0 || >=14.0.0"

This comment has been minimized.

@JLHwung

JLHwung Jul 29, 2020 Author Contributor

I feel like we can enforce the same ranges for Babel 8: that we don't have to fight against early node v13 versions that may complain about incorrect exports usage.

@JLHwung JLHwung requested a review from kaicataldo Jul 29, 2020
JLHwung added 4 commits Jul 29, 2020
This reverts commit 5ca8acd.

# Conflicts:
#	Makefile
#	eslint/babel-eslint-parser/package.json
#	eslint/babel-eslint-plugin-development/package.json
#	lerna.json
#	scripts/integration-tests/publish-local.sh
@JLHwung JLHwung force-pushed the JLHwung:eslint-packages branch from 0929326 to 51a1927 Jul 29, 2020
@@ -18,15 +18,12 @@
"author": "Kai Cataldo <kai@kaicataldo.com>",
"license": "MIT",
"private": true,
"engines": {

This comment has been minimized.

@JLHwung

JLHwung Jul 29, 2020 Author Contributor

I removed the engines requirement here because its requirement can be implied from its peerDeps: @babel/eslint-parser.

@codesandbox
Copy link

codesandbox bot commented Jul 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b708c43:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 29, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26613/

@@ -23,7 +23,7 @@
"./package.json": "./package.json"
},
"peerDependencies": {
"@babel/core": ">=7.11.0",
"@babel/core": ">=7.10.0",

This comment has been minimized.

@kaicataldo

kaicataldo Jul 30, 2020 Member

Why do we need to change this back to 7.10.0?

This comment has been minimized.

This comment has been minimized.

@kaicataldo

kaicataldo Jul 30, 2020 Member

Gotcha! So will we bump this when we do the 7.11.0 release?

This comment has been minimized.

@JLHwung

JLHwung Jul 30, 2020 Author Contributor

I think we still support 7.10? Maybe we should remove runtime peerDependencies checks, they should be addressed when installing packages.

@JLHwung JLHwung requested a review from nicolo-ribaudo Jul 30, 2020
@hzoo
hzoo approved these changes Jul 30, 2020
@JLHwung JLHwung merged commit 4c9929c into babel:main Jul 30, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.82% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:eslint-packages branch Jul 30, 2020
@kaicataldo
Copy link
Member

kaicataldo commented Jul 30, 2020

Oops, reviewed this after it was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.