Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: hardcode @babel/eslint-parser min supported version check #11896

Merged
merged 4 commits into from Jul 30, 2020

Conversation

@kaicataldo
Copy link
Member

kaicataldo commented Jul 30, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The original intent of this was to ensure that we're using a version of @babel/core that has the parse() API. The current implementation leads to peer dependency changes causing breaking changes.

Ideally, we'd like users to use the same version of @babel/core and @babel/eslint-parser to ensure compatibility, but we can figure out if we want to do anything about that (logging a message, etc.) later.

@codesandbox
Copy link

codesandbox bot commented Jul 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d5e539:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 30, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26725/

@kaicataldo kaicataldo force-pushed the kaicataldo:babel-eslint-version-match branch from ff94438 to 6d3cf3d Jul 30, 2020
Copy link
Contributor

JLHwung left a comment

We can bump package.json of @babel/eslint-parser to >=7.11.0 again.

@hzoo
hzoo approved these changes Jul 30, 2020

function baseParse(code, options) {
if (typeof isRunningSupportedVersion !== "boolean") {
isRunningSupportedVersion = semver.satisfies(
const minSupportedCoreVersion = ">=7.0.0";

This comment has been minimized.

@hzoo

hzoo Jul 30, 2020 Member

Ok so parse was added first in 7.0? (either way 7 seems good)

This comment has been minimized.

@kaicataldo

kaicataldo Jul 30, 2020 Author Member

Oh whoops, I was looking at this. Actual PR is here. Will update!

This comment has been minimized.

@kaicataldo

kaicataldo Jul 30, 2020 Author Member

@babel/core#parse() was added in 7.0.0-beta.51, but we need to bump this to 7.2.0 so that we have access to @babel/parser#tokTypes.

kaicataldo added 2 commits Jul 30, 2020
@kaicataldo kaicataldo force-pushed the kaicataldo:babel-eslint-version-match branch from 3352d50 to 96ae45e Jul 30, 2020
@kaicataldo kaicataldo changed the title update: change babel-eslint-parser version mismatch error to log update: hardcode @babel/eslint-parser min supported version check Jul 30, 2020
@existentialism
Copy link
Member

existentialism commented Jul 30, 2020

:shipit:

@JLHwung JLHwung merged commit f7ec170 into babel:main Jul 30, 2020
7 of 8 checks passed
7 of 8 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
e2e Workflow: e2e
Details
@kaicataldo kaicataldo deleted the kaicataldo:babel-eslint-version-match branch Jul 30, 2020
@kaicataldo
Copy link
Member Author

kaicataldo commented Jul 30, 2020

Thanks for reviewing this so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.