Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ExpressionBody should respect [In] parameter #11931

Merged
merged 1 commit into from Aug 26, 2020
Merged

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 7, 2020

Q                       A
Fixed Issues? Fixes #11202
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 7, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dd3da42:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Aug 7, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27125/

@@ -2110,7 +2110,8 @@ export default class ExpressionParser extends LValParser {
this.state.inParameters = false;

if (isExpression) {
node.body = this.parseMaybeAssignAllowIn();
// https://tc39.es/ecma262/#prod-ExpressionBody
node.body = this.parseMaybeAssign();

This comment has been minimized.

@JLHwung

JLHwung Aug 7, 2020
Author Contributor

After the [In] parameter tracking refactor, the fix is straightforward: parseMaybeAssign parses AssignmentExpression[?In], while parseMaybeAssignAllowIn parses AssignmentExpression[In].

According to the spec we should replace parseMaybeAssignAllowIn by parseMaybeAssign.

@JLHwung JLHwung force-pushed the JLHwung:fix-11202 branch from 7a41d58 to 70ba706 Aug 7, 2020
@JLHwung JLHwung force-pushed the JLHwung:fix-11202 branch from 70ba706 to dd3da42 Aug 10, 2020
@JLHwung JLHwung requested a review from nicolo-ribaudo Aug 11, 2020
@JLHwung JLHwung merged commit 2c60595 into babel:main Aug 26, 2020
8 of 9 checks passed
8 of 9 checks passed
build
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.62% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:fix-11202 branch Aug 26, 2020
fisker added a commit to prettier/prettier that referenced this pull request Sep 1, 2020
Test `in`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.