Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Rollup 2 #12010

Merged
merged 6 commits into from Aug 26, 2020
Merged

chore: use Rollup 2 #12010

merged 6 commits into from Aug 26, 2020

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 26, 2020

Q                       A
License MIT

Update to Rollup 2 and related plugins.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Aug 26, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27982/

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 26, 2020

I approved without noticing the failing build - why was the downgrade necessary?

@@ -153,17 +152,13 @@ function buildRollup(packages) {
// Rollup doesn't read export maps, so it loads the cjs fallback
"packages/babel-compat-data/*.js",
],
namedExports: {

This comment has been minimized.

@JLHwung

JLHwung Aug 26, 2020
Author Contributor

namedExports is removed per suggestions from @rollup/plugin-commonjs@13.

@JLHwung
Copy link
Contributor Author

@JLHwung JLHwung commented Aug 26, 2020

@nicolo-ribaudo

Test fails on commonjs@14 and build fails on commonjs@15.

I am preparing an upstream issue on build fails on commonjs@15. Before the upstream issue is resolved, let's pin commonjs to 13.0.2.

const rollupNodeGlobals = require("rollup-plugin-node-globals");
const rollupNodeResolve = require("rollup-plugin-node-resolve");
const rollupReplace = require("rollup-plugin-replace");
const rollupNodePolyfills = require("rollup-plugin-node-polyfills");

This comment has been minimized.

@JLHwung

JLHwung Aug 26, 2020
Author Contributor

rollup-plugin-node-polyfills replaces both rollup-plugin-node-globals and rollup-plugin-node-builtins. This has been done on v8 branch and now can be backported since we are not building on node.js 6.

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f1fabb:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
Copy link
Member

@existentialism existentialism left a comment

👍

@@ -27,7 +27,11 @@
"@babel/preset-flow": "^7.10.4",
"@babel/register": "^7.10.5",
"@babel/runtime": "^7.11.0",
"@rollup/plugin-json": "4.0.1",
"@rollup/plugin-babel": "^5.2.0",
"@rollup/plugin-commonjs": "^13.0.0",

This comment has been minimized.

@JLHwung

JLHwung Aug 26, 2020
Author Contributor

The latest commonjs is 15, however I have to pin to 13 due to an upstream issue: rollup/plugins#557

@JLHwung JLHwung requested a review from nicolo-ribaudo Aug 26, 2020
@JLHwung JLHwung merged commit 8d59ff6 into babel:main Aug 26, 2020
15 of 16 checks passed
15 of 16 checks passed
Prepare Cache
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.69% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:rollup-2 branch Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.