Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused enhanced-resolve and normalize lock resolutions #12013

Merged
merged 2 commits into from Aug 28, 2020

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 27, 2020

Q                       A
Any Dependency Changes? Removed unused peer deps
License MIT

See the commit message for explainers.

JLHwung added 2 commits Aug 27, 2020
It was introduced as a peer dependency of `webpack-dependency-suite`, see #7453 and https://travis-ci.org/github/babel/babel/jobs/347175454#L545
The forked @lerna/collect-updates are meant to update runtime-corejs2 when helpers
are updated. However they are now always force published. So we don't need the fork
anymore
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Aug 27, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28032/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9f9c21b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@hzoo
hzoo approved these changes Aug 27, 2020
Copy link
Member

@hzoo hzoo left a comment

🤞 yay

@JLHwung JLHwung merged commit ce6a7f1 into babel:main Aug 28, 2020
15 of 16 checks passed
15 of 16 checks passed
Prepare Cache
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.69% (target 90.00%)
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:remove-unused-dep branch Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.