Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prepublish build after versioning #12028

Merged
merged 2 commits into from Sep 3, 2020

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 1, 2020

Q                       A
Fixed Issues? After make new-version is run, make publish will fail because committed changes of yarn.lock.
License MIT

This PR reorders workflows in publish-test to align with our actual workflow. I added a "version" lifecycle event: So when we run lerna version, it will invoke the version lifecycle event after package.json is updated but before it is committed: See also https://github.com/lerna/lerna/tree/master/commands/version#lifecycle-scripts

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Sep 1, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28230/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Sep 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6305cf4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@JLHwung JLHwung requested a review from nicolo-ribaudo Sep 1, 2020
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

👍

@@ -8,7 +8,8 @@
"build": "make build",
"fix": "make fix",
"lint": "make lint",
"test": "make test"
"test": "make test",
"version": "yarn --immutable-cache && git add yarn.lock"

This comment has been minimized.

@JLHwung

JLHwung Sep 2, 2020
Author Contributor

--immutable-cache is used here to bail when new dep needs to be fetched from network, which can happen when people edit external deps in package.json but forget to checkout the updated yarn.lock, and if that happens it should be addressed in separate commits instead of the version commit. In all, the version commit should include the following changes only:

  • Updated version in related package.json
  • Updated workspace@new-version resolution in yarn.lock
@JLHwung JLHwung merged commit 2026a42 into babel:main Sep 3, 2020
15 of 16 checks passed
15 of 16 checks passed
Prepare Cache
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project Codecov Report
Details
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:run-prepublish-build-after-versioning branch Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.