Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse class static block #12079

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 18, 2020

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
License MIT

This PR implements parsing/generating support for the Stage 2 Class Static Block Proposal.

Note that current implementation is aligned to tc39/proposal-class-static-block#15.

/cc @ljharb @rbuckton

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Sep 18, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29367/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Sep 18, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e53fdfd:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@JLHwung JLHwung force-pushed the JLHwung:parse-class-static-block branch from ffd03b5 to 7ae65f3 Sep 28, 2020
@JLHwung JLHwung requested a review from nicolo-ribaudo Sep 28, 2020
Copy link
Member

@existentialism existentialism left a comment

👍 outside of a minor question around the error message

@nicolo-ribaudo nicolo-ribaudo added this to the v7.12.0 milestone Sep 30, 2020
@@ -1487,3 +1492,9 @@ export type ParseSubscriptState = {
maybeAsyncArrow: boolean,
stop: boolean,
};

export type ParseClassMemberState = {|

This comment has been minimized.

@kaicataldo

kaicataldo Oct 1, 2020
Member

TIL I learned about Flow's exact object types 👍🏼

@JLHwung JLHwung force-pushed the JLHwung:parse-class-static-block branch from c40f8e1 to 9e8864d Oct 5, 2020
@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.12.0/class-static-block Oct 6, 2020
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 6, 2020

@JLHwung I'm merging this into the feat-7.12.0/class-static-block branch, so that you can properly rebase your other PR.

@nicolo-ribaudo nicolo-ribaudo merged commit c76b519 into babel:feat-7.12.0/class-static-block Oct 6, 2020
15 of 16 checks passed
15 of 16 checks passed
Prepare Cache
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project Codecov Report
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the JLHwung:parse-class-static-block branch Oct 6, 2020
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 6, 2020
2 of 2 tasks complete
nicolo-ribaudo added a commit that referenced this pull request Oct 14, 2020
Co-authored-by: Brian Ng <bng412@gmail.com>
nicolo-ribaudo added a commit that referenced this pull request Oct 14, 2020
Co-authored-by: Brian Ng <bng412@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.