Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript mapped type 'as' clauses #12129

Merged
merged 2 commits into from Oct 14, 2020
Merged

Support TypeScript mapped type 'as' clauses #12129

merged 2 commits into from Oct 14, 2020

Conversation

@existentialism
Copy link
Member

@existentialism existentialism commented Oct 1, 2020

Q                       A
Fixed Issues?
Minor: New Feature? Y
License MIT

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 1, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29209/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 63217af:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@nicolo-ribaudo nicolo-ribaudo added this to the v7.12.0 milestone Oct 1, 2020
@existentialism existentialism force-pushed the mapped-as branch from 883c3a5 to da513f4 Oct 2, 2020
@existentialism existentialism force-pushed the mapped-as branch from da513f4 to 8bdf5d9 Oct 2, 2020
@existentialism existentialism marked this pull request as ready for review Oct 2, 2020
@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Oct 2, 2020

Note that parts of syntax changes introduced in mapped type 'as' clauses is superseded by Intrinsic string types. We should support intrinsic as keyword in TS4.1.

@JLHwung
JLHwung approved these changes Oct 2, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 6830c90 into main Oct 14, 2020
24 of 25 checks passed
24 of 25 checks passed
Prepare Cache
Details
Prepare Cache
Details
Test on Node.js Latest
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project Codecov Report
Details
e2e Workflow: e2e
Details
@nicolo-ribaudo nicolo-ribaudo deleted the mapped-as branch Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.