Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test case for babel-parser: fixtures/typescript/arrow-function/destructuring-with-annotation-newline #12203

Conversation

@Mongkii
Copy link
Contributor

@Mongkii Mongkii commented Oct 16, 2020

Q                       A
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Add test case for @babel/parser, in fixtures/typescript/arrow-function.

The test babel-parser/estree-throws will now test the situation: "Typescript arrow function with arguments destructuring, type annotations and multiline". (See below)

(
  { a, b }: T,
): T => {};

In order to avoid bugs like #12195

…ion/destructuring-with-annotation-newline
@Mongkii Mongkii changed the title test: add test case for babel-parser: fixtures/typescript/arrow-funct… test: add test case for babel-parser: fixtures/typescript/arrow-function/destructuring-with-annotation-newline Oct 16, 2020
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 16, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30318/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60e2302:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 16, 2020

Thanks!

Fyi, I'm also working on #12202 which hopefully will help catching some TS regressions in the future.

@nicolo-ribaudo nicolo-ribaudo merged commit 7870465 into babel:main Oct 16, 2020
15 of 16 checks passed
15 of 16 checks passed
Prepare Cache
Details
Test on Node.js Latest
Details
Build Babel Artifacts
Details
Test on Node.js (13)
Details
Test on Node.js (12)
Details
Test on Node.js (10)
Details
Test on Node.js (8)
Details
Test on Node.js (6)
Details
test262-pr Workflow: test262-pr
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
babel/repl REPL preview is available
Details
build-standalone Workflow: build-standalone
Details
ci/codesandbox Building packages succeeded.
Details
codecov/project 91.81% (target 90.00%)
Details
e2e Workflow: e2e
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.